Zihao Ye has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21256 )
Change subject: IMPALA-12978: Fix impala-shell`s live progress with older Impalas ...................................................................... IMPALA-12978: Fix impala-shell`s live progress with older Impalas If the Impala server has an older version that does not contain IMPALA-12048 then TExecProgress.total_fragment_instances will be None, leading to error when checking total_fragment_instances > 0. Note that this issue only comes with Python 3, in Python 2 None > 0 returns False. Testing: - Manually checked with a modified Impala that doesn't set total_fragment_instances. Only the scanner progress bar is shown in this case. Change-Id: Ic6562ff6c908bfebd09b7612bc5bcbd92623a8e6 Reviewed-on: http://gerrit.cloudera.org:8080/21256 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Zihao Ye <[email protected]> --- M shell/impala_shell.py 1 file changed, 53 insertions(+), 50 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Zihao Ye: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic6562ff6c908bfebd09b7612bc5bcbd92623a8e6 Gerrit-Change-Number: 21256 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]>
