Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 )
Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21258/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21258/2//COMMIT_MSG@9 PS2, Line 9: DIRECTED > DIRECTED Ouch, fixed in the Jira ticket as well. http://gerrit.cloudera.org:8080/#/c/21258/2//COMMIT_MSG@13 PS2, Line 13: IcebergDeleteBuilder now also tolerates NULL file paths which are > I'm wondering if there is a valid use case when a file path is null. Is it It is not valid, but we have seen such errors at certain customers. Unfortunately we don't know which engine wrote those position delete files :( But now that I think of it, with DIRECTED mode, IcebergDeleteBuilder will never get NULL file paths, as we will never have an entry for these in the routing map (filepath_to_hosts_). So I'm just keeping that logic as is and adding a DCHECK. Now it depends on KrpcDataStreamSender how we handle NULL file paths. I'll try to prepare a test table for this. -- To view, visit http://gerrit.cloudera.org:8080/21258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ba02b33433990950b49628f11e732e01ed8a34d Gerrit-Change-Number: 21258 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 11:22:22 +0000 Gerrit-HasComments: Yes
