Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 )
Change subject: IMPALA-6966: sort table memory by size in catalogd web UI ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl@57 PS1, Line 57: var i = parseInt(Math.floor(Math.log(bytes) / Math.log(1024))); It's unlikely that someone uses this for more than 1024PB, but I think you need to make sure that 0 <= i < units.length. -- To view, visit http://gerrit.cloudera.org:8080/10292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85 Gerrit-Change-Number: 10292 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 05 May 2018 04:23:09 +0000 Gerrit-HasComments: Yes
