Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 )
Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt File package/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt@25 PS8, Line 25: install(FILES ${CMAKE_SOURCE_DIR}/LICENSE.txt DESTINATION ${IMPALA_INSTALLDIR}) Thanks for adding the LICENSE file. I just filed IMPALA-12989 for this. Let's also add the NOTICE file. We also need to update the copyright year to 2024 in NOTICE.txt http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt@36 PS8, Line 36: message(FATAL_ERROR "gcc lib is empty!") Let's show the file name and the search dir in the message, e.g. message(FATAL_ERROR "libgcc_s.so not found in ${IMPALA_GCC_HOME}/lib64") http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt@42 PS8, Line 42: message(FATAL_ERROR "cpp lib is empty!") Same as above, e.g. message(FATAL_ERROR "libstdc++.so not found in ${IMPALA_GCC_HOME}/lib64") http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt@50 PS8, Line 50: message(FATAL_ERROR "kudu lib is empty!") Please update this as well. http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt@56 PS8, Line 56: message(FATAL_ERROR "hadoop lib is empty!") Please update this as well. http://gerrit.cloudera.org:8080/#/c/20263/8/package/CMakeLists.txt@97 PS8, Line 97: 3.1.3 nit: missing "hive" -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Wed, 10 Apr 2024 05:50:57 +0000 Gerrit-HasComments: Yes
