Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 )
Change subject: IMPALA-12543: Detect self-events before finishing DDL ...................................................................... Patch Set 22: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21029/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21029/22//COMMIT_MSG@24 PS22, Line 24: releases nit: released http://gerrit.cloudera.org:8080/#/c/21029/22/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21029/22/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3379 PS22, Line 3379: modification.registerInflightEvent(); Is there a reason for calling this before releasing the global version lock? registerInflightEvent() shouldn't block for long but generally we should try to move everything outside the lock if possible. -- To view, visit http://gerrit.cloudera.org:8080/21029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8365c934349ad21a4d9327fc11594d2fc3445f79 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 22 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 10 Apr 2024 16:53:08 +0000 Gerrit-HasComments: Yes
