Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21269 )
Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21269/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc File be/src/exec/iceberg-metadata/iceberg-row-reader.cc: http://gerrit.cloudera.org:8080/#/c/21269/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@135 PS1, Line 135: // Skip the unsupported type and set it to NULL > I was wrong here, DATE is present in for example the 'all_files' metadata t good catch! http://gerrit.cloudera.org:8080/#/c/21269/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/21269/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@801 PS3, Line 801: row_regex:'{2147483546:"aGRmczovL2xvY2FsaG9zdDoyMDUwMC90ZXN0LXdhcmVob3VzZS9pY2ViZXJnX3Rlc3QvaGFkb29wX2NhdGFsb2cvaWNlL2ljZWJlcmdfcXVlcnlfbWV0YWRhdGEvZGF0YS8.*",2147483545:"AAAAAAAAAAA="}','{2147483546:"aGRmczovL2xvY2FsaG9zdDoyMDUwMC90ZXN0LXdhcmVob3VzZS9pY2ViZXJnX3Rlc3QvaGFkb29wX2NhdGFsb2cvaWNlL2ljZWJlcmdfcXVlcnlfbWV0YWRhdGEvZGF0YS8.*",2147483545:"AAAAAAAAAAA="}' > We have file paths here and the file names will be different for each data Can't we provide fixed file names by using a table with copied files/manifests? I am more worried about the prefix of the path, e.g. S3:// vs HDFS:// -- To view, visit http://gerrit.cloudera.org:8080/21269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b1d7fa332a901f05a46e0199e13fb841d2687c2 Gerrit-Change-Number: 21269 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2024 15:47:40 +0000 Gerrit-HasComments: Yes
