Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21262 )
Change subject: IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test targets ...................................................................... IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test targets This patch adds a new option 'BUILD_WITH_NO_TESTS' to tell CMake not to generate test targets. In order to be consistent with the previous test workflow, this option is only set ON when building impala using the 'buildall.sh' script with '-notest' and '-package' flags. This is useful for a packaging build which do not need to build all test binaries. Testing: - Ran 'buildall.sh -release -package' with and without '-notests' flag and verified generated executables. Backport notes: resolved conflicts in following files - be/src/codegen/CMakeLists.txt - be/src/exec/parquet/CMakeLists.txt - be/src/testutil/CMakeLists.txt - be/src/util/CMakeLists.txt Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a Reviewed-on: http://gerrit.cloudera.org:8080/20294 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Quanlong Huang <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/21262 Reviewed-by: Yifan Zhang <[email protected]> Tested-by: Quanlong Huang <[email protected]> --- M be/CMakeLists.txt M be/src/benchmarks/CMakeLists.txt M be/src/catalog/CMakeLists.txt M be/src/codegen/CMakeLists.txt M be/src/common/CMakeLists.txt M be/src/exec/CMakeLists.txt M be/src/exec/parquet/CMakeLists.txt M be/src/experiments/CMakeLists.txt M be/src/exprs/CMakeLists.txt M be/src/gutil/CMakeLists.txt M be/src/rpc/CMakeLists.txt M be/src/runtime/CMakeLists.txt M be/src/runtime/bufferpool/CMakeLists.txt M be/src/runtime/io/CMakeLists.txt M be/src/scheduling/CMakeLists.txt M be/src/service/CMakeLists.txt M be/src/statestore/CMakeLists.txt M be/src/testutil/CMakeLists.txt M be/src/udf/CMakeLists.txt M be/src/udf_samples/CMakeLists.txt M be/src/util/CMakeLists.txt M be/src/util/cache/CMakeLists.txt M buildall.sh 23 files changed, 162 insertions(+), 64 deletions(-) Approvals: Yifan Zhang: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Quanlong Huang: Verified -- To view, visit http://gerrit.cloudera.org:8080/21262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: merged Gerrit-Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a Gerrit-Change-Number: 21262 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]>
