Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21294 )
Change subject: IMPALA-12874: Identify active and standby catalog and statestore the web debug endpoint ...................................................................... Patch Set 2: (2 comments) Thanks Wenzhe for reviewing. http://gerrit.cloudera.org:8080/#/c/21294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21294/1//COMMIT_MSG@15 PS1, Line 15: the : status as > nit: status as active Done http://gerrit.cloudera.org:8080/#/c/21294/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/21294/1/be/src/util/default-path-handlers.cc@283 PS1, Line 283: if (metric->GetValue()) { : document->AddMember( : "catalogd_active_status", "Active", document->GetAllocator()); : } else { : document->AddMember( : "catalogd_active_status", "Standby", document->GetAllocator()); : } > nit: this can be simplified as Tried, but the initializer of rapidjson::GenericValue seems not working this way.. -- To view, visit http://gerrit.cloudera.org:8080/21294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9435ba7a9549ea56f9d080a9315aecbcc630cd2 Gerrit-Change-Number: 21294 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2024 17:06:16 +0000 Gerrit-HasComments: Yes
