Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21186 )
Change subject: IMPALA-12933: Avoid fetching unneccessary events of unwanted types ...................................................................... Patch Set 14: (3 comments) Refactored some lengthy codes. http://gerrit.cloudera.org:8080/#/c/21186/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21186/13//COMMIT_MSG@27 PS13, Line 27: and t > nit: and this approach can be simplified Done http://gerrit.cloudera.org:8080/#/c/21186/13//COMMIT_MSG@31 PS13, Line 31: A new flag, default_skipped_hms_event_types, is added to configure : this > This seems like a duplicate after line 24 Oops, wrote a wrong name here.. http://gerrit.cloudera.org:8080/#/c/21186/13/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21186/13/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@361 PS13, Line 361: : // Total number of dbs, tables and functions in the catalog cache. : // Updated in each catalog topic update (getCatalogDelta()). : private int numDbs_ = 0; : private int numTables_ = 0; > This comment could get stale easily - maybe point to the flag instead? Done -- To view, visit http://gerrit.cloudera.org:8080/21186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieabe714328aa2cc605cb62b85ae8aa4bd537dbe9 Gerrit-Change-Number: 21186 Gerrit-PatchSet: 14 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Apr 2024 01:42:36 +0000 Gerrit-HasComments: Yes
