Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 )
Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/21277/7/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21277/7/be/src/scheduling/scheduler.cc@1210 PS7, Line 1210: in at nit: change to "is with" http://gerrit.cloudera.org:8080/#/c/21277/7/be/src/scheduling/scheduler.cc@1210 PS7, Line 1210: is nit: remove "is" or change to "that is" http://gerrit.cloudera.org:8080/#/c/21277/7/be/src/scheduling/scheduler.cc@1211 PS7, Line 1211: scheduler only assign nit: "the schedule would only assign" http://gerrit.cloudera.org:8080/#/c/21277/7/be/src/scheduling/scheduler.cc@1213 PS7, Line 1213: // dominant plan subtree ('dominant_instance_count' is 0). Comment/terminology is overall hard to follow here. Is this referring to any fragment that would include the coordinator? Unclear why rounding up is the neccesary action. http://gerrit.cloudera.org:8080/#/c/21277/7/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/21277/7/common/thrift/Query.thrift@133 PS7, Line 133: Scheduler nit: The scheduler -- To view, visit http://gerrit.cloudera.org:8080/21277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5441e31088f90761062af35862be4ce09d116923 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2024 12:14:48 +0000 Gerrit-HasComments: Yes
