Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21310 )
Change subject: IMPALA-12679: Improve test_rows_sent_counters assert ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21310/1/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/21310/1/tests/query_test/test_fetch.py@27 PS1, Line 27: class TestFetch(ImpalaTestSuite): I'm surprised gerrit-code-review-checks didn't complain about spacing, I thought our linter required 2 newlines before a class. http://gerrit.cloudera.org:8080/#/c/21310/1/tests/query_test/test_fetch.py@68 PS1, Line 68: rpc_count = int(re.search("RPCCount: ([5-9])", runtime_profile).group(1)) If rpc_count is not in the range 5-9, re.search will return None and this will error. I think you need to capture any integer pattern, then run the assert. Or update the old code to print the runtime_profile on assertion failure: assert re.search("RPCCount: [5-9]", runtime_profile), runtime_profile -- To view, visit http://gerrit.cloudera.org:8080/21310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b48cf4039028e749c914ee60b88f04833a0069 Gerrit-Change-Number: 21310 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2024 21:50:36 +0000 Gerrit-HasComments: Yes
