Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21320 )
Change subject: IMPALA-13000: Document OPTIMIZE TABLE ...................................................................... Patch Set 1: (5 comments) Thanks Noémi! http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@553 PS1, Line 553: many small, : delete It doesn't feel right for me, maybe "can write many small data files and/(as well as) delete files. http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@554 PS1, Line 554: update Do we have 'update files'? My understanding is that an update adds new data files and delete files. If this is correct, I don't think we should call them 'update files'. Of course we should mention that updates (as well as deletes and inserts) contribute to the problem. http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@556 PS1, Line 556: db_name Do we always have to use the fully qualified name? If not, it may not be important to include the database name here. http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@577 PS1, Line 577: <li>Views cannot be optimized.</li> Maybe take it out of the list into a separate paragraph because it doesn't fit well with the introduction of the list ("To execute table optimization:"). http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@585 PS1, Line 585: </conbody> Do you think it would be worth to add a warning that because OPTIMIZE re-writes the whole table, it can take a long time, so it shouldn't be called too often? -- To view, visit http://gerrit.cloudera.org:8080/21320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851669686ed4da610dcac97c9b88ff23b0a4a647 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Apr 2024 13:47:28 +0000 Gerrit-HasComments: Yes
