Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21326 )
Change subject: IMPALA-13009: Fix catalogd not sending deletion updates for some dropped partitions ...................................................................... Patch Set 2: (1 comment) Thanks for the quick review! http://gerrit.cloudera.org:8080/#/c/21326/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21326/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1075 PS2, Line 1075: if (addedPartNames.contains(part.partition_name)) continue; > What does this case means? The partition was dropped, but was readded later Yeah, if a partition is dropped and then re-added, the droppedPartitions will have the old instance and the partitionMap will have the new instance. When the table is dropped/invalidated, partitions from the partitionMap are collected in the for-loop at L1057. Some of them could have the same partition name as those in the dropped_partitions. Renamed 'addedPartNames' to 'collectedPartNames' to avoid confusion. -- To view, visit http://gerrit.cloudera.org:8080/21326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12a68158dca18ee48c9564ea16b7484c9f5b5d21 Gerrit-Change-Number: 21326 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 10:49:47 +0000 Gerrit-HasComments: Yes