Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21315 )
Change subject: IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Thanks, just some nits. http://gerrit.cloudera.org:8080/#/c/21315/2/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21315/2/be/src/exprs/ai-functions.inline.h@108 PS2, Line 108: move 'Move' is good from the context of the change, but if someone is reading the new code it's a bit strange. I think "place" or "put" would be better. http://gerrit.cloudera.org:8080/#/c/21315/2/be/src/exprs/ai-functions.inline.h@108 PS2, Line 108: loop Nit: it is not a loop, I wrote it wrong in my comment. "'if' statement" would be better. -- To view, visit http://gerrit.cloudera.org:8080/21315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bb9dcf9d72cce7ad37d5bc25821cf6ee55a8ab5 Gerrit-Change-Number: 21315 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 12:54:05 +0000 Gerrit-HasComments: Yes
