Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@59 PS4, Line 59: TImpalaTableProperty.__IMPALA_SYSTEM_TABLE.toString()); > Moved this property to CatalogObjects.thrift. I forgot about that as a simp Yeah, I think const string with TBL_PROP_ prefix is better. A property key may have dot or other char that is not valid as Thrift identifier. We have few of those const string already. $ git grep -n "const string" common/thrift/ common/thrift/CatalogService.thrift:44:const string CATALOG_TOPIC_V1_PREFIX = "1:"; common/thrift/CatalogService.thrift:48:const string CATALOG_TOPIC_V2_PREFIX = "2:"; common/thrift/hive-1-api/TCLIService.thrift:184:const string CHARACTER_MAXIMUM_LENGTH = "characterMaximumLength" common/thrift/hive-1-api/TCLIService.thrift:187:const string PRECISION = "precision" common/thrift/hive-1-api/TCLIService.thrift:188:const string SCALE = "scale" -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 18:16:29 +0000 Gerrit-HasComments: Yes
