Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 )
Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 ...................................................................... Patch Set 3: (1 comment) > Patch Set 1: > > > Patch Set 1: > > > > Thanks Laszlo for working on this! > > > > On my Ubuntu 20.04.6 LTS I had to add -fPIC to CXXFLAGS otherwise I got > > strange linker errors. Though I switched to GoogleTest 1.14.0 in a quite > > hacky way, so maybe it was just because of that. Did you try this out on > > Ubuntu 20? > > Not yet (although I definitely want to run it through some upstream-like > testing), but it's a good point, thanks for calling it out. For the record: In the meantime -fPIC has been added to CFLAGS and CXXFLAGS in general, in init_compiler.sh http://gerrit.cloudera.org:8080/#/c/21133/1/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/21133/1/buildall.sh@227 PS1, Line 227: ################################# > I think we can remove this? There are some references in the ORC build.sh a Done -- To view, visit http://gerrit.cloudera.org:8080/21133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa52b4809a7c969e863518b182d2df63256f4c43 Gerrit-Change-Number: 21133 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 21 Apr 2024 20:14:32 +0000 Gerrit-HasComments: Yes
