Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21302/8/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/21302/8/common/thrift/CatalogObjects.thrift@676 PS8, Line 676: // Table names can be found in SystemTable.java Is this comment still valid, or the table name is lowercase(TSystemTableName)? http://gerrit.cloudera.org:8080/#/c/21302/8/common/thrift/CatalogObjects.thrift@678 PS8, Line 678: IMPALA_QUERY_LIVE = 0 Please add comment for TSystemTableName and TQueryTableColumn to not change their enum value identifiers, since they are matter now. -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2024 23:56:04 +0000 Gerrit-HasComments: Yes
