Hello Bikramjeet Vig, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10314
to look at the new patch set (#3).
Change subject: IMPALA-6970: race with decreasing scanner reservation
......................................................................
IMPALA-6970: race with decreasing scanner reservation
The usage pattern of DecreaseReservationTo() in
ReturnReservationFromScannerThread() can decrease the reservation by
more than 'bytes' if there is a concurrent IncreaseReservation() call.
The API is changed to fit the requirements of the scanner, which
does not want to release more than the memory reserved for that
scanner thread.
Testing:
Added some backend tests (including concurrency) for the new API.
Change-Id: I653225c981bf674d2b2b947f3a3cb4d8f382d36b
---
M be/src/benchmarks/bloom-filter-benchmark.cc
M be/src/exec/exec-node.cc
M be/src/exec/exec-node.h
M be/src/exec/hdfs-scan-node.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
8 files changed, 74 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/10314/3
--
To view, visit http://gerrit.cloudera.org:8080/10314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I653225c981bf674d2b2b947f3a3cb4d8f382d36b
Gerrit-Change-Number: 10314
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
