Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21351 )
Change subject: IMPALA-13012: Lower default query_log_max_queued ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21351/4/be/src/service/internal-server.h File be/src/service/internal-server.h: http://gerrit.cloudera.org:8080/#/c/21351/4/be/src/service/internal-server.h@62 PS4, Line 62: std::map<string, string> nit: This can be std::map<TImpalaQueryOptions::type, string>; TImpalaQueryOptions::type is defined in ./be/generated-sources/gen-cpp/ImpalaService_types.h Enum to String can be done through _TImpalaQueryOptions_VALUES_TO_NAMES. But Enum to String to Enum again in SetQueryOption() might be redundant. Might be a good idea to make an overload function: Status SetQueryOption(const TImpalaQueryOptions::type& key, const std::string& value, TQueryOptions* query_options, QueryOptionsMask* set_query_options_mask); -- To view, visit http://gerrit.cloudera.org:8080/21351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6535675307d88cb65ba7d908f3c692e0cf3259d7 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 25 Apr 2024 22:47:18 +0000 Gerrit-HasComments: Yes
