Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 )
Change subject: IMPALA-12935: First pass on Calcite planner functions ...................................................................... Patch Set 2: (2 comments) Rebase is done now. Will add a better comment in a bit. http://gerrit.cloudera.org:8080/#/c/21357/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java: http://gerrit.cloudera.org:8080/#/c/21357/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@119 PS2, Line 119: public static List<RelDataType> createRelDataTypesForArgs(List<Type> impalaTypes) { > How does this differ from createRelDataTypes at line 318? Unused, deleted it. http://gerrit.cloudera.org:8080/#/c/21357/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@130 PS2, Line 130: public static RelDataType getRelDataType(Type impalaType) { > I'm not sure why this and createRelDataType both exist. They're very simila The getRelDataType deals with datatypes where the precision and scale might not be known. The "normalized" comment probably wasn't clear enough, and I know "get" and "create" can be confusing. "get" was meant to convey that these datatypes already exist in a map, whereas "create" will grab the precision and scale from the Type passed in and "create" a new datatype. I'll try to make the comment clearer. -- To view, visit http://gerrit.cloudera.org:8080/21357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd4e402d69ee10547abeeafe893164ffd789b88 Gerrit-Change-Number: 21357 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 29 Apr 2024 15:15:06 +0000 Gerrit-HasComments: Yes
