Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21304 )
Change subject: IMPALA-12910: Support running TPCH/TPCDS queries for JDBC tables ...................................................................... Patch Set 18: (8 comments) http://gerrit.cloudera.org:8080/#/c/21304/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21304/17//COMMIT_MSG@11 PS17, Line 11: Note > nit: Note that ... fixed http://gerrit.cloudera.org:8080/#/c/21304/17//COMMIT_MSG@19 PS17, Line 19: 5 minutes > Should this duration be configurable? Yes, added a flag variable. http://gerrit.cloudera.org:8080/#/c/21304/17//COMMIT_MSG@26 PS17, Line 26: > nit: Note that ... fixed http://gerrit.cloudera.org:8080/#/c/21304/17/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/21304/17/be/src/service/frontend.cc@99 PS17, Line 99: DEFINE_int32(dbcp_max_conn_pool_size, 8, > Is this a per query limit or a coordinator level limit? Maybe, also mention This is coordinator level limit for each pool. Updated comments. http://gerrit.cloudera.org:8080/#/c/21304/17/be/src/service/frontend.cc@103 PS17, Line 103: "to all DBCP connection pools created on the coordinator."); > If -1 is indefinite, 0 means immediately returns error? Yes. Updated the comments. http://gerrit.cloudera.org:8080/#/c/21304/17/common/thrift/ExternalDataSource.thrift File common/thrift/ExternalDataSource.thrift: http://gerrit.cloudera.org:8080/#/c/21304/17/common/thrift/ExternalDataSource.thrift@144 PS17, Line 144: reference count equals 0 > reference count is tracked across all queries for a given data source in a Yes, updated comments. http://gerrit.cloudera.org:8080/#/c/21304/17/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java: http://gerrit.cloudera.org:8080/#/c/21304/17/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@91 PS17, Line 91: > what's a typical cache key here? Adding comments would be useful. Added comments. http://gerrit.cloudera.org:8080/#/c/21304/17/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@144 PS17, Line 144: } > Some comments explaining when cleanup() is called would be good. Is it at s This function is running on a working thread in the coordinator daemon, clean up idle DataSource in every 10 seconds. Added comments for this function. -- To view, visit http://gerrit.cloudera.org:8080/21304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44e8c1bb020e90559c7f22483a7ab7a151b8f48a Gerrit-Change-Number: 21304 Gerrit-PatchSet: 18 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Apr 2024 21:04:07 +0000 Gerrit-HasComments: Yes
