Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 )
Change subject: IMPALA-13029: Tests for multi format equality deletes ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21348/3/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh File testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh: http://gerrit.cloudera.org:8080/#/c/21348/3/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh@4 PS3, Line 4: # Usage: ./avro_iceberg_convert.sh <AVRO_FILE> 'hdfs://localhost:20500/test-warehouse/' '/test-warehouse/' line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/21348/3/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh@30 PS3, Line 30: #These updates the manifest files and their length probably change. Snapshot files store the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21348/3/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh@31 PS3, Line 31: #length of the manifest files, so it need to be changed as well. If it only stores one manifest: line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21348/3/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh@36 PS3, Line 36: #If a snapshot has multiple manifest files, then you need to change manually the previously generated line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21348/3/testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_multiple_avro_equality_deletes/metadata/avro_iceberg_convert.sh@37 PS3, Line 37: #*_json files and transform it back using avro tools, the last step of avro_iceberg_convert.sh, or line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f0ebf7f4d401877741eb3e1c990f1318ac2b4ba Gerrit-Change-Number: 21348 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2024 15:42:44 +0000 Gerrit-HasComments: Yes
