Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 )
Change subject: IMPALA-12559: Support x5c Parameter in JSON Web Keys ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/21382/6/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/21382/6/be/src/util/jwt-util.cc@217 PS6, Line 217: Value& json_value = j unused parameter. From function name, this function only works for array property http://gerrit.cloudera.org:8080/#/c/21382/6/be/src/util/jwt-util.cc@256 PS6, Line 256: value[i] = json_value[i].GetString(); \ : } \ : > Done The for loop block should be indented with 4 spaces. http://gerrit.cloudera.org:8080/#/c/21382/6/be/src/util/jwt-util.cc@323 PS6, Line 323: if (it_x5c != kv_map.end()) > We check each key regardless to validate them. If "k" is invalid, then the Is it possible there is no 'k' property when 'x5c' is provided? http://gerrit.cloudera.org:8080/#/c/21382/7/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/21382/7/be/src/util/jwt-util.cc@55 PS7, Line 55: array_type nit: use upper case for constants -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 7 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2024 18:20:50 +0000 Gerrit-HasComments: Yes
