Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 )
Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21383/1/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: http://gerrit.cloudera.org:8080/#/c/21383/1/be/src/runtime/query-exec-mgr.cc@85 PS1, Line 85: RETURN_IF_ERROR(DebugAction(query_ctx.client_request.query_options.debug_action, > Maybe we need to add a query option to fix those for testing so we can have Changed the test and debug action in ps2. http://gerrit.cloudera.org:8080/#/c/21383/1/be/src/service/data-stream-service.cc File be/src/service/data-stream-service.cc: http://gerrit.cloudera.org:8080/#/c/21383/1/be/src/service/data-stream-service.cc@126 PS1, Line 126: const UpdateFilterParamsPB* req, UpdateFilterResultPB* resp, RpcContext* context) { > It share the same RPC queue with TransmitData (KRPC exchanges). There is a I figured the downside of this approach is that RPC thread will blocked until filter update finally applied or wait period pass. I fix wait period to 500ms to not hold RPC thread for too long. http://gerrit.cloudera.org:8080/#/c/21383/1/be/src/service/data-stream-service.cc@166 PS1, Line 166: } while (total_wait_time < min_wait_time_ms); > Ack. "no longer running" sound better. Done http://gerrit.cloudera.org:8080/#/c/21383/1/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/21383/1/tests/query_test/test_runtime_filters.py@555 PS1, Line 555: > The longer SLEEP debug action should log error. I'll see if I can add that. Done -- To view, visit http://gerrit.cloudera.org:8080/21383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I156d1f0c694b91ba34be70bc53ae9bacf924b3b9 Gerrit-Change-Number: 21383 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2024 00:49:16 +0000 Gerrit-HasComments: Yes
