Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21387 )
Change subject: IMPALA-13036: Document Iceberg metadata tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21387/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/21387/1/docs/topics/impala_iceberg.xml@729 PS1, Line 729: > nit:, I don't think a comma is needed before "and". http://gerrit.cloudera.org:8080/#/c/21387/1/docs/topics/impala_iceberg.xml@730 PS1, Line 730: fr > I'm not sure: from? Yes, neither is perfect, I changed it to "from". http://gerrit.cloudera.org:8080/#/c/21387/1/docs/topics/impala_iceberg.xml@730 PS1, Line 730: > nit:, I don't think a comma is needed here. http://gerrit.cloudera.org:8080/#/c/21387/1/docs/topics/impala_iceberg.xml@730 PS1, Line 730: > *direclty Added a sentence at the end to make it clearer. http://gerrit.cloudera.org:8080/#/c/21387/1/docs/topics/impala_iceberg.xml@770 PS1, Line 770: > *are The subject is "unnesting", which is singular, that's why it's "is". -- To view, visit http://gerrit.cloudera.org:8080/21387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic453f567b814cb4363a155e2008029e94efb6ed1 Gerrit-Change-Number: 21387 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2024 09:45:39 +0000 Gerrit-HasComments: Yes
