Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 )
Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Carry +2. http://gerrit.cloudera.org:8080/#/c/10265/3/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/10265/3/be/src/rpc/thrift-util.cc@178 PS3, Line 178: IsConnResetTExceptio > is that talking about IsConnResetTException? Yes, I changed it now. Thanks for catching that. http://gerrit.cloudera.org:8080/#/c/10265/3/be/src/rpc/thrift-util.cc@201 PS3, Line 201: 0.9.0, since in 0.9.3 > Is there a way to validate this behavior ? I think it's fairly clear from reading the code. If it does turn out that we missed something, then we should see ECONNRESET errors in our logs on 'master' (which has 0.9.3). -- To view, visit http://gerrit.cloudera.org:8080/10265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2 Gerrit-Change-Number: 10265 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 08 May 2018 17:21:02 +0000 Gerrit-HasComments: Yes
