Hello Andrew Sherman, Riza Suminto, Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21392
to look at the new patch set (#2).
Change subject: IMPALA-13054: Avoid revisiting children in QueryStateExpanded
......................................................................
IMPALA-13054: Avoid revisiting children in QueryStateExpanded
Avoids revisiting children in QueryStateExpanded due to duplicate
recursion. Since process_exec_profile visits children recursively, we
only want immediate children from GetChildren, not all children from
GetAllChildren.
Adjusts HDFS_SCAN_NODE test to look back at top of stack, rather than
depend on a specific depth that was caused by calling GetAllChildren
from the root.
This was identified by running the Impala E2E test suite with workload
management enabled, where
test_nested_types.py::TestMaxNestingDepth::test_max_nesting_depth took
multiple hours to run and blocked the FinishUnregisterQuery for other
tests.
Testing:
- Manual test with enable_workload_mgmt=true running
test_max_nesting_depth.
Change-Id: Ia36d53e52095d487ffb3a162fc723f1e815bec11
---
M be/src/service/query-state-record.cc
1 file changed, 23 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/21392/2
--
To view, visit http://gerrit.cloudera.org:8080/21392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36d53e52095d487ffb3a162fc723f1e815bec11
Gerrit-Change-Number: 21392
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
