Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21376 )
Change subject: IMPALA-13047: Support restarting/killing specified impalads in start-impala-cluster.py ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@95 PS1, Line 95: Start > Nit: Starts. Done http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@260 PS1, Line 260: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@275 PS1, Line 275: # find_user_processes() returns a generator. Consumes the tuples from it so > Could use "list(find_user_processes(binary_names))" instead of list compreh Good point! Done. http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@277 PS1, Line 277: kill_processes(list(find_user_processes(binary_names)), force) > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@833 PS1, Line 833: > Optional: could extract into a variable, also used on L840. Done http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@1118 PS1, Line 1118: existing_cluster_size = cluster_ops.get_cluster().get_max_impalad_id() + 1 > If we kill some impalads, doesn't that change the cluster size? Yeah, that's an issue. Removed this check when using --kill. Also improved the code of getting the existing cluster size. -- To view, visit http://gerrit.cloudera.org:8080/21376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a863853341959eb6870b662d82188e7d570971 Gerrit-Change-Number: 21376 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 06 May 2024 10:25:34 +0000 Gerrit-HasComments: Yes
