Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20979 )
Change subject: IMPALA-12607: Bump the GBN and fetch events specific to the db/table from the metastore ...................................................................... Patch Set 9: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20979/9/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20979/9/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@466 PS9, Line 466: metaDataFilter = new MetaDataFilter(getTableNotificationEventFilter(tbl)); Can you add a comment on why the ACID/external cases are different? http://gerrit.cloudera.org:8080/#/c/20979/9/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/20979/9/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4017 PS9, Line 4017: 3 testInsertIntoTransactionalTable also does an insert - this doesn't lead to new events, because transaction events are not specific to db, right? -- To view, visit http://gerrit.cloudera.org:8080/20979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aecd5108b31c24e6e2c6f9fba6d4d44a3b00729 Gerrit-Change-Number: 20979 Gerrit-PatchSet: 9 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2024 07:22:45 +0000 Gerrit-HasComments: Yes
