Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21160 )
Change subject: IMPALA-12921: Support locally built Ranger ...................................................................... Patch Set 10: (2 comments) Hi all, I have revised patch set 7 according to Quanlong's comments. Please ignore patch sets 8 and 9 since I made some mistakes when addressing Quanlong's comments. Let me know if there is any additional suggestion. I plan to collect the list of passed authorization-related tests when Apache Ranger is used with this patch and will update on this when the results are available. http://gerrit.cloudera.org:8080/#/c/21160/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21160/7//COMMIT_MSG@64 PS7, Line 64: - Verified that this patch passed the core tests when CDP Ranger is > Do you mean using Apache Ranger? That would be great! Thanks Quanlong! I only verified that this patch passed the core tests with CDP Ranger. I will clarify this in the commit message of the next patch. I could try to collect the list of passed authorization-related tests when the patched Apache Ranger (with RANGER-4771.diff on top of RANGER-4745) is used. http://gerrit.cloudera.org:8080/#/c/21160/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/21160/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@500 PS7, Line 500: req.setResource(resource); > It seems using the empty constructor and setting the fields later is a more Thanks Quanlong! I will revise this accordingly in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/21160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I268d6d4d6e371da7497aac8d12f78178d57c6f27 Gerrit-Change-Number: 21160 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 07 May 2024 08:49:26 +0000 Gerrit-HasComments: Yes
