[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 25: (5 comments) > Uploaded patch set 25. http://gerrit.cloudera.org:8080/#/c/21131/23/be/src/util/coding-util-test.cc File be/src/util/coding-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21131/23/be/src/util/coding-util-test.cc@94 PS23, Line 94: string test_path = "/home/impala/directory/"; > These strings could also be extracted into variables. Done http://gerrit.cloudera.org:8080/#/c/21131/23/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/21131/23/tests/query_test/test_insert.py@320 PS23, Line 320: is > "is a" Done http://gerrit.cloudera.org:8080/#/c/21131/23/tests/query_test/test_insert.py@320 PS23, Line 320: the result > "the result line..." Done http://gerrit.cloudera.org:8080/#/c/21131/23/tests/query_test/test_insert.py@321 PS23, Line 321: we only verify that the value is present in str > "we only verify that the value is present in string representation of the w Done http://gerrit.cloudera.org:8080/#/c/21131/24/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/21131/24/tests/query_test/test_insert.py@301 PS24, Line 301: "create table {}(i int) partitioned by (p string) stored as parquet".format(tbl)) I've added a new test for iceberg, since there are a lot of differences in how we create, insert and how show partition works in iceberg, I've skipped the helper function to improve the readabilty. The only thing that was left common were a few asserts and the strings. I also think that if we're to add any new tests for iceberg, it'd be easier and more convenient if it'll have a separate function. I've an optimized version for the same as well and have shared the same with you, but I think it just gets more complicated when we'll need to handle iceberg and parquet tables separately because of their show partition evaluation. -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 25 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2024 19:56:02 +0000 Gerrit-HasComments: Yes
