Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21405 )

Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ 
with -1
......................................................................


Patch Set 4:

(1 comment)

> Patch Set 4: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10615/

ubuntu-20.04-from-scratch job fail doing apt-get install

15:54:13 + sudo apt-get --yes install git
15:54:13 E: Could not get lock /var/lib/dpkg/lock-frontend. It is held by 
process 2804 (apt-get)
15:54:13 E: Unable to acquire the dpkg frontend lock 
(/var/lib/dpkg/lock-frontend), is another process using it?

http://gerrit.cloudera.org:8080/#/c/21405/4/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/21405/4/be/src/service/client-request-state.cc@123
PS4, Line 123: query_events_->Start(query_events_start_time);
I'd like to revert this back to query_events_->Start(), since it already moved 
to beginning of constructor and calling MonotonicStopWatch::Now() twice feels 
overkill.



--
To view, visit http://gerrit.cloudera.org:8080/21405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58
Gerrit-Change-Number: 21405
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 08 May 2024 04:04:37 +0000
Gerrit-HasComments: Yes

Reply via email to