Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 )
Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/21382/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21382/6//COMMIT_MSG@22 PS6, Line 22: > Could you add test case in fe/test/java/org/apache/impala/customcluster/Jwt Please add end-end test case. http://gerrit.cloudera.org:8080/#/c/21382/10/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/21382/10/be/src/util/jwt-util.cc@403 PS10, Line 403: nit: extra spaces -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 10 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2024 16:18:52 +0000 Gerrit-HasComments: Yes
