Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 )
Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Looks good, couple of questions that may not need code changes depending on the answer. http://gerrit.cloudera.org:8080/#/c/21383/4/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21383/4/be/src/scheduling/scheduler.cc@341 PS4, Line 341: if (FLAGS_sort_runtime_filter_aggregator_candidates) { Would it be worthwhile to wrap this condition with UNLIKELY since the flag is intended for testing? http://gerrit.cloudera.org:8080/#/c/21383/4/be/src/service/data-stream-service.cc File be/src/service/data-stream-service.cc: http://gerrit.cloudera.org:8080/#/c/21383/4/be/src/service/data-stream-service.cc@159 PS4, Line 159: } else if (qs->is_initialized()) { Is this condition the more likely to happen? If so, please make it the if condition and the existing if condition becomes the else if: if (qs->is_initialized()) { ... } else if (qs.get() == nullptr || qs->IsCancelled() || qs->IsTerminalState()) { ... } -- To view, visit http://gerrit.cloudera.org:8080/21383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I156d1f0c694b91ba34be70bc53ae9bacf924b3b9 Gerrit-Change-Number: 21383 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2024 18:18:22 +0000 Gerrit-HasComments: Yes
