Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 )
Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY ...................................................................... Patch Set 2: > Assuming that one change is done, this looks good. > > Just as a reference, fe/src/main/cup/sql-parser.cup defines our > parsing rules. The variable that shows the ordering is tbl_options > (apart from the "partitioned by"). The "partitioned by" comes from > a couple different places. Sometimes it is hard coded with > "KW_PARTITIONED KW_BY". Sometimes it comes from partitioned_data_layout. > Sometimes it comes from partition_column_defs. > Assuming that one change is done, this looks good. > > Just as a reference, fe/src/main/cup/sql-parser.cup defines our > parsing rules. The variable that shows the ordering is tbl_options > (apart from the "partitioned by"). The "partitioned by" comes from > a couple different places. Sometimes it is hard coded with > "KW_PARTITIONED KW_BY". Sometimes it comes from partitioned_data_layout. > Sometimes it comes from partition_column_defs. Thank you! I will make a note. -- To view, visit http://gerrit.cloudera.org:8080/10316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03fd4a308981955bb52ca79772fe2f7c01b5894f Gerrit-Change-Number: 10316 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 08 May 2018 20:46:15 +0000 Gerrit-HasComments: No
