Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 )
Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/common/init.cc@548 PS1, Line 548: FLAGS_thrift_external_rpc_max_message_size < ThriftDefaultMaxMessageSize() > I don't understand these checks and error message. Why do we force the conf The intention is to enforce a minimum for the rpc max message size. Someone shouldn't be able to set it to 1 KB. What makes it a bit awkward is that we let someone set it to 0 or negative and get the Thrift default. We could change the error message to make it clear that 0/negative gets the Thrift default. We could stop allowing people to set it to 0/negative and just force a positive number at or above the Thrift default. I'm thinking about whether we should enforce an upper bound. -- To view, visit http://gerrit.cloudera.org:8080/21420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a649ef49a8a99c7bd9a1b73c37c4c621661311 Gerrit-Change-Number: 21420 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2024 19:08:41 +0000 Gerrit-HasComments: Yes
