Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thank you, Daniel! I left a minor comment. http://gerrit.cloudera.org:8080/#/c/21425/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/21425/1/testdata/datasets/functional/functional_schema_template.sql@3916 PS1, Line 3916: INSERT INTO {db_name}{db_suffix}.{table_name} VALUES ( nit: More rows with different values could give better insight into how upper/lower/nan count/value count changes in the newly added test case. -- To view, visit http://gerrit.cloudera.org:8080/21425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29 Gerrit-Change-Number: 21425 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 15 May 2024 07:08:22 +0000 Gerrit-HasComments: Yes
