Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21188 )

Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is 
invisible to the impala server user
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21188/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21188/2//COMMIT_MSG@15
PS2, Line 15: note: This is an incorrect, where 'impala' super user is denied 
access
you mean that this an incorrect setup?


http://gerrit.cloudera.org:8080/#/c/21188/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/21188/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1462
PS2, Line 1462:         // if the database is not found in the cache, then 
ignore this event
Can you also mention here that this is an incorrect setup in general but we 
still don't want to stop the event processor because of it?



--
To view, visit http://gerrit.cloudera.org:8080/21188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90275bb8c065fc5af61186901ac7e9839a68c43b
Gerrit-Change-Number: 21188
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 May 2024 04:17:33 +0000
Gerrit-HasComments: Yes

Reply via email to