Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10330 )
Change subject: IMPALA-6227: reduce window of metric inconsistency ...................................................................... IMPALA-6227: reduce window of metric inconsistency The admission controller test fetches multiple metrics relating to the admission controller. Before this patch it fetched the whole metrics list for each metric, meaning there was a substantial window for the metrics to be inconsistent for a single backend. Now the metrics are only fetched once. Metric updates are not transactional so there is still a small window for raciness if an admission decision is made exactly when the metrics are fetched. Also try to detect the specific race between updating "dequeued" and "admitted" that we saw in practice, since the race is still possible with a smaller window. In that case we retry getting the metrics. Change-Id: I2f16edbec53e49446c4c37ef5f926eedb5604319 Reviewed-on: http://gerrit.cloudera.org:8080/10330 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M bin/start-impala-cluster.py M tests/common/impala_service.py M tests/custom_cluster/test_admission_controller.py 3 files changed, 34 insertions(+), 8 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2f16edbec53e49446c4c37ef5f926eedb5604319 Gerrit-Change-Number: 10330 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
