Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 )
Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21367/5/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/21367/5/be/src/rpc/thrift-util.cc@63 PS5, Line 63: "Default to the upper limit of 2147483647 bytes (~2GB). " > "Default to the upper limit" seems misleading, as it's no longer the upper This is all reworded in the next patch, so it's probably fine. -- To view, visit http://gerrit.cloudera.org:8080/21367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I681b1849cc565dcb25de8c070c18776ce69cbb87 Gerrit-Change-Number: 21367 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 17 May 2024 17:49:14 +0000 Gerrit-HasComments: Yes
