Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 )
Change subject: IMPALA-12935: First pass on Calcite planner functions ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/21357/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/21357/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java@69 PS10, Line 69: //TODO: Don't throw runtime exception > If you're planning to leave TODOs in when we commit, please add the JIRA ti Done http://gerrit.cloudera.org:8080/#/c/21357/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java: http://gerrit.cloudera.org:8080/#/c/21357/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java@76 PS10, Line 76: // There shouldn't be more than one opName with our usage, so throw an exception > Why is that? How is "our usage" unique? So this is more of a TODO if anything. For the most part, a function name should have one operator. When I was researching this months ago, I think I saw situations where some of the other parameters to this method (ie. category, syntax) can be used with opName. I don't think we care about that. I don't want to say I'm 100% sure though. So I put in this exception to catch a case if it was missed. Another important note on top of this: the Parser.jj still needs to be stripped a bit to only handle Impala functions. This is still a work in progress. So my theory is that once we strip out other noise, we won't have situations with 2 opNames for the same operator. Not sure I totally answered your question, but yeah, the short summary is that I want to catch situations in case this happens, but I don't think it will happen without usage. But we'll be able to catch it quickly if it does. -- To view, visit http://gerrit.cloudera.org:8080/21357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd4e402d69ee10547abeeafe893164ffd789b88 Gerrit-Change-Number: 21357 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 17 May 2024 17:58:24 +0000 Gerrit-HasComments: Yes
