Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 )
Change subject: IMPALA-12705: Add /catalog-ha-info page on Starstore to show catalog HA information ...................................................................... Patch Set 6: (7 comments) Thanks to add this enhancement for catalog HA. http://gerrit.cloudera.org:8080/#/c/21418/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21418/6//COMMIT_MSG@7 PS6, Line 7: Starstore nit: typo statestore http://gerrit.cloudera.org:8080/#/c/21418/6//COMMIT_MSG@9 PS6, Line 9: Starstor typo statestore http://gerrit.cloudera.org:8080/#/c/21418/6//COMMIT_MSG@11 PS6, Line 11: Subscribers nit: wrap up long line http://gerrit.cloudera.org:8080/#/c/21418/6//COMMIT_MSG@20 PS6, Line 20: Should we add unit-test for this new page? http://gerrit.cloudera.org:8080/#/c/21418/6/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/21418/6/be/src/statestore/statestore.cc@652 PS6, Line 652: catalogd_version_ = catalogd_version; need to acquire lock before updating. http://gerrit.cloudera.org:8080/#/c/21418/6/be/src/statestore/statestore.cc@2245 PS6, Line 2245: subscriber.second->subscriber_type() == TStatestoreSubscriberType::CATALOGD : || subscriber.second->IsCoordinator() can replace with subscriber.second->IsSubscribedCatalogdChange() http://gerrit.cloudera.org:8080/#/c/21418/6/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/21418/6/common/thrift/StatestoreService.thrift@222 PS6, Line 222: registration_time_ms This is timestamp, not time period. Name with appendix '_ms' sounds like period, i.e. 'time in milliseconds'. -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 6 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 21 May 2024 01:14:09 +0000 Gerrit-HasComments: Yes
