Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21438 )
Change subject: IMPALA-13093: Fix failure in inserting into OBS tables ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21438/1/be/src/exec/table-sink-base.cc File be/src/exec/table-sink-base.cc: http://gerrit.cloudera.org:8080/#/c/21438/1/be/src/exec/table-sink-base.cc@326 PS1, Line 326: IsOBSPath(tmp_hdfs_file_name_cstr) || It'd make more sense at this point to invert this check: if IsHDFSPath. -- To view, visit http://gerrit.cloudera.org:8080/21438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2441da0fc521b4b1111bed10c8edceb937bde481 Gerrit-Change-Number: 21438 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2024 22:04:00 +0000 Gerrit-HasComments: Yes
