Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 )
Change subject: IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/20221/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/20221/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@931 PS11, Line 931: nit. unnecessary newline http://gerrit.cloudera.org:8080/#/c/20221/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3241 PS11, Line 3241: nit. unnecessary newline http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py@87 PS11, Line 87: Impala does not throw an AnalysisException Am I right in saying that if a ranger user doesn't have write permissions, this patch will allow the analysis check to pass but eventually result in another exception in this insertion case because the user lacks the necessary rights? -- To view, visit http://gerrit.cloudera.org:8080/20221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id33c400fbe0c918b6b65d713b09009512835a4c9 Gerrit-Change-Number: 20221 Gerrit-PatchSet: 11 Gerrit-Owner: Halim Kim <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Halim Kim <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 25 May 2024 16:05:30 +0000 Gerrit-HasComments: Yes
