Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21458 )
Change subject: IMPALA-13107: Don't start query on executor if instance number equals 0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21458/1/be/src/service/control-service.cc File be/src/service/control-service.cc: http://gerrit.cloudera.org:8080/#/c/21458/1/be/src/service/control-service.cc@154 PS1, Line 154: fragment_info.fragments.size() == 0 : || fragment_info.fragment_instance_ctxs.size() == 0 Can you also add DCHECK in Coordinator::BackendState::SetRpcParams verifying that these vectors are never left empty by coordinator? ImpalaInternalService.thrift mention this, but I don't see any assertion for it: // The Thrift portion of the execution parameters of a single fragment instance. Every // fragment instance will also have a corresponding PlanFragmentInstanceCtxPB with the // same fragment_idx. // TODO: convert the rest of this struct to protobuf struct TPlanFragmentInstanceCtx { -- To view, visit http://gerrit.cloudera.org:8080/21458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie92ee120f1e9369f8dc2512792a05b7f8be5f007 Gerrit-Change-Number: 21458 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2024 19:22:41 +0000 Gerrit-HasComments: Yes
