Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21477
Change subject: IMPALA-13129: Move runtime filter skipping at registerRuntimeFilter ...................................................................... IMPALA-13129: Move runtime filter skipping at registerRuntimeFilter A DCHECK in hdfs-scanner.h was hit when skipping a MIN_MAX runtime filter using RUNTIME_FILTER_IDS_TO_SKIP query option. This is because HdfsScanNode.tryToComputeOverlapPredicate() is called and register a TOverlapPredicateDesc during runtime filter generation, but the minmax filter is then skipped later, causing backend to hit DCHECK. This patch move the runtime filter skipping at registerRuntimeFilter() so that HdfsScanNode.tryToComputeOverlapPredicate() will not be called at all once a filter is skipped. Testing: - Add test in overlap_min_max_filters.test to explicitly skip a minmax runtime filter. - Pass test_runtime_filters.py Change-Id: I43c1c4abc88019aadaa85d2e3d0ecda417297bfc --- M be/src/exec/hdfs-scanner.h M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test 3 files changed, 40 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/21477/1 -- To view, visit http://gerrit.cloudera.org:8080/21477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I43c1c4abc88019aadaa85d2e3d0ecda417297bfc Gerrit-Change-Number: 21477 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
