Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21480 )
Change subject: IMPALA-13134: DDL hang with SYNC_DDL enabled when Catalogd is changed to standby status ...................................................................... Patch Set 2: (2 comments) Thanks Riza for your feedback. http://gerrit.cloudera.org:8080/#/c/21480/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21480/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3515 PS2, Line 3515: BackendConfig.INSTANCE.debugActions() > Maybe use debug action from ddlRequest.getQuery_options().getDebug_action() ddlRequest is not available in this function so we have to add additional parameter to pass query_option. But waitForSyncDdlVersion() is also called from CatalogOpExecutor.execResetMetadataImpl() where query_option is not available in TResetMetadataRequest. TResetMetadataRequest has a field 'debug_action', but it seems not been set properly. http://gerrit.cloudera.org:8080/#/c/21480/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3519 PS2, Line 3519: if (!serviceId.equals(JniCatalog.getServiceId())) { > Should this check done closer to L3544 (just before topicUpdateLog_.wait(TO Prefer to make it failed earlier. -- To view, visit http://gerrit.cloudera.org:8080/21480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dcd628cff3c10d2e7566ba2d9de0b5886a18fc1 Gerrit-Change-Number: 21480 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2024 18:58:11 +0000 Gerrit-HasComments: Yes
