Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 )
Change subject: IMPALA-12935: First pass on Calcite planner functions ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/21357/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/21357/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java@33 PS12, Line 33: /** : * A FunctionCallExpr that is always in an analyzed state : */ > I'll address this as a follow-up. Starting to think about this a little more... Yeah, I guess I'm not sure I like the post analysis solution. I would rather do something within the Expr class to remove the "resetAnalysisState" method. This is a mutable expression and has caused me major grief on some bugs in the past. It just feels wrong to me to have an analyzeImpl method that mutates the object. I think a general redesign should be done, as I mentioned in the previous post. So it leaves me at a crossroads. Do I implement it the way you suggested which is slightly more in line with the current way of doing things but makes the code more vulnerable to problems? Or do I address the major issue which is a major change to the system? Chances are I probably do it the way you suggested and that causes me a bit of pain. But we can discuss this in a later code review. -- To view, visit http://gerrit.cloudera.org:8080/21357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd4e402d69ee10547abeeafe893164ffd789b88 Gerrit-Change-Number: 21357 Gerrit-PatchSet: 12 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2024 23:13:37 +0000 Gerrit-HasComments: Yes
