Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21433 )
Change subject: IMPALA-13076 Add pstack and jstack to Impala Redhat docker images ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21433/2/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/21433/2/docker/install_os_packages.sh@27 PS2, Line 27: INSTALL_BASIC_DEBUG_TOOLS=true To me, it's a bit weird to have this variable here with no real hookup to anything. Nothing turns it on or off. I also just remembered that the packaging code uses this script to generate its dependency list for RPMs, etc, so we should be defaulting to off. One option is something like this: 1. Change --install-debug-tools to take an argument of "none", "basic", "full" (the actual names of the levels are negotiable). basic = gdb + jdk, full = basic + existing list of debug tools (Maybe there is a name better than --install-debug-tools) 2. Default to none 3. Change docker/CMakeLists.txt to pass "--install-debug-tools basic" for release images and "--install-debug-tools full" for debug images. -- To view, visit http://gerrit.cloudera.org:8080/21433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25e6827b86564a9c0fc25678e4a194ee8e0be0e9 Gerrit-Change-Number: 21433 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 01:52:25 +0000 Gerrit-HasComments: Yes
