Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21491 )

Change subject: IMPALA-13134 (part 2): Fix flaky 
test_catalogd_failover_with_sync_ddl
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21491/1/tests/custom_cluster/test_catalogd_ha.py
File tests/custom_cluster/test_catalogd_ha.py:

http://gerrit.cloudera.org:8080/#/c/21491/1/tests/custom_cluster/test_catalogd_ha.py@35
PS1, Line 35: 5000
Is catalogd restart tend to slow? What factor in long catalogd restart time?
What if we double the base delay to 10s and 20s for slow build flavor?


http://gerrit.cloudera.org:8080/#/c/21491/1/tests/custom_cluster/test_catalogd_ha.py@470
PS1, Line 470: catalogds[1].start(wait_until_ready=True,
             :                        
additional_args="--force_catalogd_active=true")
Can we log/assert the time until second catalogd active?


http://gerrit.cloudera.org:8080/#/c/21491/1/tests/custom_cluster/test_catalogd_ha.py@475
PS1, Line 475: timeout=15
Should this be adjusted too?



--
To view, visit http://gerrit.cloudera.org:8080/21491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15bb6aae23a2f544067f993533e322969372ebd5
Gerrit-Change-Number: 21491
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 07 Jun 2024 15:34:25 +0000
Gerrit-HasComments: Yes

Reply via email to